Report WaitingStatus for relations that have not requested user & database
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atabase Previously, `WaitingStatus` was only reported if no other database_provides relations were active. However, if a relation is established but we're waiting for data, it makes more sense to set `WaitingStatus` instead of `ActiveStatus`, even though the charm is active on one relation
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
carlcsaposs-canonical
added a commit
to canonical/mysql-router-k8s-operator
that referenced
this pull request
Jun 28, 2023
paulomach
approved these changes
Jun 29, 2023
taurus-forever
approved these changes
Jun 30, 2023
carlcsaposs-canonical
added a commit
to canonical/mysql-router-k8s-operator
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
WaitingStatuswas only reported if no other database_provides relations were active. However, if a relation is established but we're waiting for data, it makes more sense to setWaitingStatusinstead ofActiveStatus, even though the charm is active on one relation