Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transfer only partially transferring #3902

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sploder12
Copy link
Contributor

Fixes the issue of multipass transfer only transferring some chunks of the file. This uses sftp_limits instead of the constant 65536u to determine the correct buffer size for SFTP reads and writes.

Fixes #3892
MULTI-1768

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (620770e) to head (dca86e4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3902   +/-   ##
=======================================
  Coverage   89.11%   89.11%           
=======================================
  Files         255      255           
  Lines       14600    14602    +2     
=======================================
+ Hits        13011    13013    +2     
  Misses       1589     1589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end! Tested with the ingredients.tar.gz in the linked issue and they had the same md5sum after transferring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multipass transfer only transfers half the file (every 2nd 32K block)
2 participants