From 0a7f88064c938c742264704d80d77dd7391bd808 Mon Sep 17 00:00:00 2001 From: Nick De Villiers Date: Thu, 5 Dec 2024 14:32:34 +0000 Subject: [PATCH] fix: Add "Tested with" before Ubuntu version in kernel crash dump OS requirement tooltips (#5558) - Tooltips showing the minimum Ubuntu version for enabling kernel crash dumps now say "Tested with" before the version number. --- .../DeployFormFields/DeployFormFields.test.tsx | 2 +- .../DeployForm/DeployFormFields/DeployFormFields.tsx | 10 ++++++---- .../KernelParametersForm/KernelParametersForm.test.tsx | 2 +- .../KernelParametersForm/KernelParametersForm.tsx | 7 +++---- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.test.tsx b/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.test.tsx index 34b612d976..681b00feef 100644 --- a/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.test.tsx +++ b/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.test.tsx @@ -726,7 +726,7 @@ describe("DeployFormFields", () => { await waitFor(() => { expect(screen.getByRole("tooltip")).toHaveTextContent( - "Ubuntu 24.04 LTS or higher." + "Tested with Ubuntu 24.04 LTS or higher." ); }); }); diff --git a/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.tsx b/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.tsx index bb67f8cb71..055bac402e 100644 --- a/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.tsx +++ b/src/app/machines/components/MachineForms/MachineActionFormWrapper/DeployForm/DeployFormFields/DeployFormFields.tsx @@ -291,13 +291,15 @@ export const DeployFormFields = (): JSX.Element => { } />{" "} - and OS{" "} + must meet the minimum requirements and the OS{" "} {" "} - must meet the minimum requirements and secure boot must be - disabled. Check crash dump status in machine details. + must support it. Check crash dump status in machine details.{" "} + + More about kernel crash dump + } label={ diff --git a/src/app/settings/views/Configuration/KernelParametersForm/KernelParametersForm.test.tsx b/src/app/settings/views/Configuration/KernelParametersForm/KernelParametersForm.test.tsx index 8864f88d32..c952824975 100644 --- a/src/app/settings/views/Configuration/KernelParametersForm/KernelParametersForm.test.tsx +++ b/src/app/settings/views/Configuration/KernelParametersForm/KernelParametersForm.test.tsx @@ -128,7 +128,7 @@ describe("KernelParametersForm", () => { await waitFor(() => { expect(screen.getByRole("tooltip")).toHaveTextContent( - "Ubuntu 24.04 LTS or higher." + "Tested with Ubuntu 24.04 LTS or higher." ); }); }); diff --git a/src/app/settings/views/Configuration/KernelParametersForm/KernelParametersForm.tsx b/src/app/settings/views/Configuration/KernelParametersForm/KernelParametersForm.tsx index f808a4b9d7..d4ae62bd50 100644 --- a/src/app/settings/views/Configuration/KernelParametersForm/KernelParametersForm.tsx +++ b/src/app/settings/views/Configuration/KernelParametersForm/KernelParametersForm.tsx @@ -86,13 +86,12 @@ const KernelParametersForm = (): JSX.Element => { } />{" "} - and OS{" "} + must meet the minimum requirements and the OS{" "} {" "} - must meet the minimum requirements and secure boot must be disabled. - Check crash dump status in machine details.{" "} + must support it. Check crash dump status in machine details.{" "} More about kernel crash dump