Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests pass in a build environment #269

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

wck0
Copy link
Contributor

@wck0 wck0 commented Sep 12, 2024

Some recent changes caused the tests to fail in a package building environment where there is no landscape user. These changes allow setting environment variables to configure the user that runs in a build environment.

@wck0
Copy link
Contributor Author

wck0 commented Sep 13, 2024

To test, follow our debian build instructions to the point where you can do pbuilder-dist jammy amd64 build landscape_client*.dsc and check the build is successful.

Copy link
Contributor

@srunde3 srunde3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Build was successful and tests pass under pbuilder-dist.

@wck0 wck0 merged commit 24e8b51 into canonical:main Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants