Add non-filtered interfaces to the API response (LP: #2052834) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srunde3
requested changes
May 29, 2024
landscape/lib/tests/test_network.py
Outdated
| continue | ||
| print("result is: ", result) |
There was a problem hiding this comment.
Please remove this print from the tests
snap-http
Outdated
There was a problem hiding this comment.
We'll want to make sure this submodule is up-to-date prior to the merge
|
Thank you for the review @srunde3! I added the docstring and removed the print statement, it was a debug remnant. Let me know if anything else needs changing. |
|
Manual testing looks good:
Note that these additional interfaces might not appear in the UI still since I believe that data comes from the HardwareInfo plugin. The UI is getting updated anyways, so this could be a moot point. |
srunde3
approved these changes
May 30, 2024
|
Thank you for the review and for merging the patch! Yes you are correct these interfaces still do no show up in the UI, my goal was for them to show up in the API requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not all interfaces show up in the API response (interfaces with no IP address, in the down state, etc...).
This patch makes any interface that is not filtered out and has a valid MAC address show up in the API response. All previously included interfaces will still show up as expected.
Mainly interfaces in the down state as well as interfaces in the up state but with no IP address assigned to them will now show up in the API response as long as they have a MAC address.
The IP address, broadcast address and net-mask for these interfaces will be set to
0.0.0.0.