Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration for snap #234

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

srunde3
Copy link
Contributor

@srunde3 srunde3 commented Mar 26, 2024

The snap cannot call the pro client to get Ubuntu Pro info, which occurs during registration. We still need ubuntu_pro_info to be called during registration to provide mocked pro info for Core (i.e., Core snap) management.

https://bugs.launchpad.net/landscape-client/+bug/2059136

Copy link
Contributor

@wck0 wck0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

Copy link
Collaborator

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@srunde3 srunde3 merged commit a88cd8e into canonical:master Mar 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants