Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expandvars): replace bash shell expansion with custom routine #222

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix(expandvars): replace bash shell expansion with custom routine #222

merged 1 commit into from
Feb 29, 2024

Conversation

st3v3nmw
Copy link
Collaborator

@st3v3nmw st3v3nmw commented Feb 29, 2024 •
edited
Loading

The previous shell expansion left us vulnerable to code injection attacks. This change should address that.

Perfect5th
Perfect5th approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@Perfect5th Perfect5th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Apologies again for the back-and-forth on this function.

@Perfect5th Perfect5th merged commit 2e64ecf into canonical:master Feb 29, 2024
5 checks passed
@st3v3nmw st3v3nmw deleted the expandvars branch February 29, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Perfect5th Perfect5th Perfect5th approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st3v3nmw @Perfect5th