fix: user management on classic snap #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3v3nmw
force-pushed
the
fix-user-reporting-on-ubuntu-classic-2
branch
from
bc79697
to
5ecefff
Compare
st3v3nmw
force-pushed
the
fix-user-reporting-on-ubuntu-classic-2
branch
from
5ecefff
to
948db70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #210 introduced user management on Core, user management on Ubuntu classic broke since the
LANDSCAPE_CLIENT_COREenvironment variable is hardcoded to1regardless of whether the snap is installed on classic or core. This change will rely on theSNAP_SAVE_DATAvariable instead since that is only set on Core systems.Ubuntu classic uses
/etc/shadowbut Core systems use/var/lib/extrausers/shadowhttps://snapcraft.io/docs/environment-variables