-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move snap services to separate manager & monitor #217
refactor: move snap services to separate manager & monitor #217
Conversation
We need to be a bit careful here. Releasing this client version without backporting the fix to still-supported server versions will break those server versions. I'd like to suggest a non-backward-breaking option instead: we use a different message type for snap services. Server automatically ignores message types it isn't aware of, and that way reporting installed snaps will still work even if reporting services doesn't. The new message type can still be sent by |
6b9a1e7
to
6bdb14f
Compare
I've refactored the code to introduce a separate manager and monitor set for snap services ( Also fixed the Tested that reporting of installed snaps is working as before and that the new |
0688297
to
a9fd015
Compare
a9fd015
to
d757bb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks!
Also tested against current version of landscape-server. Seems good. |
Makes sure the extraservices
field doesn't trip up the server after the next landscape server release