Remote script execution for snaps #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcw-work
commented
Jan 31, 2024
mcw-work
commented
- Enable remote script execution in the snap.
- When a snap execute all scripts as root (confined by the snap)
- Add LD_LIBRARY and PYTHONPATH env variables to script execution environment.
* When a snap execute all scripts as root (confined by the snap) * Add LD_LIBRARY and PYTHONPATH env variables to script execution environment.
Perfect5th
requested changes
Jan 31, 2024
Perfect5th
requested changes
Jan 31, 2024
Restructure IS_SNAP tests
Update test to match script env_vars
|
updated tests to match changes to script execution. |
|
Added unit tests for when script is called from a snap |
|
Tests all passed |
Perfect5th
reviewed
Feb 13, 2024
|
Yeap - I have installed it on a x86 classic machine and a pi core device and they both work fine. The scripts that are saved in the snap-management-demo account on the staging server are also tested and verified as working - that includes one as a heredoc, one using REST API directly and one using Snap-HTTP. Stephen and Yanisa are having a look at what we need to document as well so we don't fall too far behind with that. |
Perfect5th
requested changes
Feb 16, 2024
Perfect5th
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.