Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-init Unknown network_data link type: macvtap #2755

Closed
ubuntu-server-builder opened this issue May 10, 2023 · 9 comments
Closed

cloud-init Unknown network_data link type: macvtap #2755

ubuntu-server-builder opened this issue May 10, 2023 · 9 comments
Labels
launchpad Migrated from Launchpad

Comments

@ubuntu-server-builder
Copy link
Collaborator

This bug was originally filed in Launchpad as LP: #1639263

Launchpad details
affected_projects = []
assignee = oddbloke
assignee_name = Dan Watkins
date_closed = 2019-05-10T18:05:55.996506+00:00
date_created = 2016-11-04T14:39:51.581346+00:00
date_fix_committed = 2019-03-04T18:41:10.029121+00:00
date_fix_released = 2019-05-10T18:05:55.996506+00:00
id = 1639263
importance = undecided
is_complete = True
lp_url = https://bugs.launchpad.net/cloud-init/+bug/1639263
milestone = None
owner = gkeuken
owner_name = Greg Keuken
private = False
status = fix_released
submitter = gkeuken
submitter_name = Greg Keuken
tags = []
duplicates = []

Launchpad user Greg Keuken(gkeuken) wrote on 2016-11-04T14:39:51.581346+00:00

Cloud Init failing due to unknown network data link type: macvtap

Sample cloud_init.log output of launched instance where compute running neutron-macvtap-agent

[CLOUDINIT] util.py[WARNING]: failed stage init-local
[CLOUDINIT] util.py[DEBUG]: failed stage init-local#012Traceback (most recent call last):#12 File "/usr/lib/python3/dist-packages/cloudinit/cmd/main.py", line 521, in status_wrapper#012 ret = functor(name, args)#12 File "/usr/lib/python3/dist-packages/cloudinit/cmd/main.py", line 280, in main_init#012 init.apply_network_config(bring_up=bool(mode != sources.DSMODE_LOCAL))#12 File "/usr/lib/python3/dist-packages/cloudinit/stages.py", line 631, in apply_network_config#012 netcfg, src = self._find_networking_config()#12 File "/usr/lib/python3/dist-packages/cloudinit/stages.py", line 618, in _find_networking_config#012 if self.datasource and hasattr(self.datasource, 'network_config'):#12 File "/usr/lib/python3/dist-packages/cloudinit/sources/DataSourceConfigDrive.py", line 159, in network_config#012 self.network_json, known_macs=self.known_macs)#12 File "/usr/lib/python3/dist-packages/cloudinit/sources/helpers/openstack.py", line 627, in convert_net_json#012 'Unknown network_data link type: %s' % link['type'])#012ValueError: Unknown network_data link type: macvtap

@ubuntu-server-builder ubuntu-server-builder added the launchpad Migrated from Launchpad label May 10, 2023
@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Dan Watkins(oddbloke) wrote on 2019-02-19T17:15:01.797791+00:00

Hi Greg,

Sorry we haven't go to this before, but we are doing bug triage now. Is this still an issue you're seeing?

Thanks!

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Greg Keuken(gkeuken) wrote on 2019-02-19T17:37:21.846293+00:00

Hello,

Yes .. this was reported in 16.04 and the same bug was experienced in 18.04 as well.

My workaround was simply to add macvtap to the acceptable types in:
/usr/lib/python3/dist-packages/cloudinit/sources/helpers/openstack.py

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Dan Watkins(oddbloke) wrote on 2019-02-21T09:23:33.539096+00:00

Instead of my initial plan to just add macvtap to the list (as suggested by Greg), we are planning to modify the behaviour of the OpenStack datasource to assume that any device types that it doesn't otherwise know about are physical devices, but log a warning when we see a type that isn't known to be an OpenStack physical type. This should unblock people who are hitting this issue (whilst warning them that they have an unusual-looking OpenStack configuration), without us having to expand this list every time a new type is seen in the wild.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Dan Watkins(oddbloke) wrote on 2019-02-21T10:07:08.680294+00:00

Greg,

I'm looking at writing a test to make sure that we don't regress this; could you run cloud-init collect-logs on a failing instance and attach the output to this bug? That will allow me to write a test using real-world data.

Thanks!

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Dan Watkins(oddbloke) wrote on 2019-02-21T10:11:16.284870+00:00

My mistake, collect-logs doesn't include the necessary data for this bug in case it contains sensitive user data. Please grab /run/cloud-init/instance-data.json from a failing instance, check that you're happy having the data therein public, and attach it to the bug.

Thanks!

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Greg Keuken(gkeuken) wrote on 2019-02-21T14:53:03.539540+00:00

Hello,

I've moved on to a different job role/area so I no longer have appropriate access to perform the above mentioned work in the Openstack environment. I will pass along this info to the person who has taken over my past responsibilities so that they may provide the input.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Dan Watkins(oddbloke) wrote on 2019-02-21T15:03:15.308422+00:00

Thanks Greg! I think we can probably synthesise something that'll work fine, so if it's too much trouble don't worry about it.

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Server Team CI bot(server-team-bot) wrote on 2019-03-04T18:41:08.211879+00:00

This bug is fixed with commit 5352dd9 to cloud-init on branch master.
To view that commit see the following URL:
https://git.launchpad.net/cloud-init/commit/?id=5352dd99

@ubuntu-server-builder
Copy link
Collaborator Author

Launchpad user Chad Smith(chad.smith) wrote on 2019-05-10T18:05:57.943752+00:00

This bug is believed to be fixed in cloud-init in version 19.1. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
launchpad Migrated from Launchpad
Projects
None yet
Development

No branches or pull requests

1 participant