Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fields like so_id and molecule_context are in Tokenizer schemas, but should be moved to Classification schemas. For molecule_context we should use ga4gh.vrsatile.pydantic #428

Closed
Tracked by #162
korikuzma opened this issue May 10, 2023 · 1 comment · Fixed by #474
Closed
Tracked by #162

Some fields like so_id and molecule_context are in Tokenizer schemas, but should be moved to Classification schemas. For molecule_context we should use ga4gh.vrsatile.pydantic #428

korikuzma opened this issue May 10, 2023 · 1 comment · Fixed by #474
Assignees
@korikuzma
Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@korikuzma
Copy link
Member

No description provided.

@korikuzma korikuzma mentioned this issue May 10, 2023
Closed
5 tasks
@korikuzma korikuzma added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels May 10, 2023
@korikuzma korikuzma self-assigned this May 10, 2023
@korikuzma korikuzma mentioned this issue May 10, 2023
Merged
@korikuzma korikuzma mentioned this issue Jul 27, 2023
Merged
@korikuzma korikuzma linked a pull request Jul 29, 2023 that will close this issue
refactor!: clean up app #474
Merged
@korikuzma korikuzma mentioned this issue Aug 21, 2023
Merged
@github-actions
Copy link

Closed by #494.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: clean up app cancervariants/variation-normalization
1 participant
@korikuzma