From 4fb36d726dc4dc91ed018955eb4548a5f3fe4bff Mon Sep 17 00:00:00 2001 From: Josh Wulf Date: Wed, 8 May 2024 11:03:40 +1200 Subject: [PATCH] fix(repo): fix example in README (#154) (#155) Give a correct example constructor of Camunda8 in the README fixes #153 --- .github/workflows/unit.yml | 3 +++ README.md | 6 +----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml index 35c636b1..f6dedcc9 100644 --- a/.github/workflows/unit.yml +++ b/.github/workflows/unit.yml @@ -40,6 +40,9 @@ jobs: - name: Build run: npm run build + - name: Build and Smoke Test + run: npm run test:smoketest + - name: Run Unit Tests run: | npm run test diff --git a/README.md b/README.md index dc66eb24..8905826f 100644 --- a/README.md +++ b/README.md @@ -104,9 +104,7 @@ Here is an example of specifying a different cache directory via the constructor import { Camunda8 } from '@camunda8/sdk' const c8 = new Camunda8({ - config: { - CAMUNDA_TOKEN_CACHE_DIR: '/tmp/cache', - }, + CAMUNDA_TOKEN_CACHE_DIR: '/tmp/cache', }) ``` @@ -149,7 +147,6 @@ Here is an example of doing this via the constructor, rather than via the enviro import { Camunda8 } from '@camunda8/sdk' const c8 = new Camunda8({ - config: { ZEEBE_ADDRESS: 'localhost:26500' ZEEBE_CLIENT_ID: 'zeebe' ZEEBE_CLIENT_SECRET: 'zecret' @@ -160,7 +157,6 @@ const c8 = new Camunda8({ CAMUNDA_MODELER_BASE_URL: 'http://localhost:8070/api' CAMUNDA_TENANT_ID: '' // We can override values in the env by passing an empty string value CAMUNDA_SECURE_CONNECTION: false - } }) ```