-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade operator and revamp module #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll mark this PR as draft since for the time being I need to troubleshoot this with @modridi because I could not bootstrap the devops-stack realm using the new CRD. |
lentidas
force-pushed
the
module_revamp
branch
from
January 30, 2023 15:15
6317b77
to
1361373
Compare
lentidas
force-pushed
the
module_revamp
branch
from
February 10, 2023 16:13
af37dc7
to
62a7282
Compare
modridi
reviewed
Feb 20, 2023
Co-authored-by: Mohamed Amine Dridi <78367821+modridi@users.noreply.github.com>
Co-authored-by: Mohamed Amine Dridi <78367821+modridi@users.noreply.github.com>
modridi
previously approved these changes
Feb 21, 2023
modridi
previously approved these changes
Feb 22, 2023
modridi
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely revamps this module. It updates the Keycloak operator and the way Keycloak is deployed. It also provides a new way to bootstrap the DevOps Stack realm, since the Keycloak team depreciated the CRDs used before to deploy said resources.
This could be a v1.0.0, as far as I'm concerned.