Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use automated tests #535

Closed
henriquecbuss opened this issue May 14, 2021 · 0 comments · Fixed by #582
Closed

Use automated tests #535

henriquecbuss opened this issue May 14, 2021 · 0 comments · Fixed by #582
Assignees
Labels
🧰 enhancement Changes and improvements to what we already have

Comments

@henriquecbuss
Copy link
Member

What we have
Right now we test everything manually, which makes it easy to let some edge cases slip in to the final build. Our development process goes like this right now:

  1. Produce code
  2. Test locally
  3. Fix code if needed
  4. Get a review from a teammate, and fix the code if needed. Repeat this until the PR is approved
  5. Ask one of the designers to test the PR. If they request changes, go back to 4.
  6. Once a dev and a designer have approved the PR, be happy and merge it.

Proposal
We should start using automated tests

Why
This would improve the overall quality of our app, and ensure we don't break anything between updates. We also would require less time from the design team to test things, which means they gain time and we gain time, win-win!

How
Probably using elm-test initially. In the future, we could look into tools like Selenium to do some more advanced tests.

Additional context
N/A

@henriquecbuss henriquecbuss added the 🧰 enhancement Changes and improvements to what we already have label May 14, 2021
@henriquecbuss henriquecbuss self-assigned this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 enhancement Changes and improvements to what we already have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant