Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make '+' mandatory for phoneNumber #50

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Make '+' mandatory for phoneNumber #50

merged 1 commit into from
Apr 4, 2024

Conversation

bigludo7
Copy link
Collaborator

@bigludo7 bigludo7 commented Apr 3, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Make '+' mandatory for phoneNumber as specified in Commonalities.

Which issue(s) this PR fixes:

Fixes #47

Special notes for reviewers:

I've changed the version to v0.6.0-wip as we have released the v0.5.0

As Dawid is not able to review and Fernando still not codeowners I tagged you Herbert for help.

Changelog input

 release-note
- Make '+' mandatory for phoneNumber

Additional documentation

This section can be blank.

docs

Make '+' mandatory for phoneNumber
@hdamker
Copy link
Contributor

hdamker commented Apr 3, 2024

As Dawid is not able to review and Fernando still not codeowners I tagged you Herbert for help.

@bigludo7 happy to help. Approved and invited @fernandopradocabrillo to the sub project. As soon he accepts the invite the codeowner file will get valid.

@hdamker hdamker removed the request for review from DT-DawidWroblewski April 3, 2024 16:43
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 merged commit 554c73d into main Apr 4, 2024
@bigludo7 bigludo7 deleted the bigludo7-patch-4 branch April 4, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandate '+' in phoneNumber
3 participants