Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align subscription-APIs with guidelines for error scenarios #184

Closed
maxl2287 opened this issue Jul 8, 2024 · 2 comments · Fixed by #193
Closed

Align subscription-APIs with guidelines for error scenarios #184

maxl2287 opened this issue Jul 8, 2024 · 2 comments · Fixed by #193
Assignees
Labels
enhancement New feature or request Fall24 RC1

Comments

@maxl2287
Copy link
Contributor

maxl2287 commented Jul 8, 2024

Problem description
Current version still does not follow the recent guidelines.

Possible evolution
Align codes and examples as indicated in:

https://github.com/camaraproject/Commonalities/blob/main/artifacts/camara-cloudevents/event-subscription-template.yaml

@maxl2287 maxl2287 added the enhancement New feature or request label Jul 8, 2024
@maxl2287 maxl2287 self-assigned this Jul 8, 2024
@maxl2287 maxl2287 added the Fall24 label Jul 8, 2024
@akoshunyadi
Copy link
Collaborator

We've aligned with the event-subscription-template.yaml, shouldn't that be first aligned with the guideline? @bigludo7

@bigludo7
Copy link
Collaborator

We've aligned with the event-subscription-template.yaml, shouldn't that be first aligned with the guideline? @bigludo7

Yes! we need to align our template yaml with the commonalities.
@maxl2287 have you already done the gap list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fall24 RC1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants