Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Device attribute optional in device-roaming-status & device-reachability-status #173

Closed
bigludo7 opened this issue Jun 19, 2024 · 3 comments · Fixed by #179
Closed
Assignees
Labels

Comments

@bigludo7
Copy link
Collaborator

Problem description
As discussed in Commonalities issue#171 & PR233 we need to shift the device object to optional.

Expected behavior
Apply the mechanism to rely on the access_token (not providing the device object in the API request) for 3-legged access scenarios. This would fix interoperability in all these scenarios, which is a huge improvement. We can define the device identifier as optional in the API specification and, if not provided, simply refer to access_tokehttps://github.com/camaraproject/Commonalities/pull/233n. The developer would simply not provide any further device information, which is simpler. The operator does not need to check that the device identifier actually matches the access_token provided and could simply rely on the access_token itself.

Alternative solution

Additional context

@bigludo7 bigludo7 added v0.6.0 Planned for release v0.6.0 Fall24 labels Jun 19, 2024
@bigludo7 bigludo7 self-assigned this Jun 19, 2024
@maxl2287
Copy link
Contributor

Hi @bigludo7,
is this also required for the subscription-APIs?

@maxl2287 maxl2287 removed the v0.6.0 Planned for release v0.6.0 label Jun 21, 2024
@bigludo7
Copy link
Collaborator Author

bigludo7 commented Jul 3, 2024

Hi @bigludo7, is this also required for the subscription-APIs?

Fair question !
The subscription will be handled by 3-legs so I guess getting the phone number via the access token is perfectly valid... consequently the phone number could be optional.
So regarding your question for me Yes

To simplify our work we can probably craft 2 PR: one under your name for the 2 subscriptions yaml and one for me for the 2 other APIs. Works for you?

@maxl2287
Copy link
Contributor

maxl2287 commented Jul 3, 2024

@bigludo7, Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants