Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 422 UNIDENTIFIABLE_DEVICE error in Service Exceptions table (§6.1) #249

Closed
bigludo7 opened this issue Jul 17, 2024 · 5 comments · Fixed by #256
Closed

Add 422 UNIDENTIFIABLE_DEVICE error in Service Exceptions table (§6.1) #249

bigludo7 opened this issue Jul 17, 2024 · 5 comments · Fixed by #256
Labels
documentation Improvements or additions to documentation

Comments

@bigludo7
Copy link
Collaborator

Problem description
Very small one....

In Appendix A: info.description template for device identification from access token we can read:

If the device object is not included in the request and
the device information cannot be derived from the 3-legged access token, the server will return a 422 UNIDENTIFIABLE_DEVICE error.

.... but 422 UNIDENTIFIABLE_DEVICE error is not in Service Exceptions table (§6.1)

Expected action
Add 422 UNIDENTIFIABLE_DEVICE error in Service Exceptions table (§6.1)

Additional context
@rartych as it seems to be a straightforward i can probably craft the PR? wdyt?

@bigludo7 bigludo7 added the documentation Improvements or additions to documentation label Jul 17, 2024
@rartych
Copy link
Contributor

rartych commented Jul 17, 2024

Yes, I agree - it is correction for consistency between Chapter 6 and Appendix A.

@bigludo7
Copy link
Collaborator Author

Thanks @rartych - Will do.
As I'm not codeowner I cannot create branch and as I have already forked for #251 so will wait resolution of this later before to create a new one.

@PedroDiez
Copy link
Contributor

Also would make sense to incorporate HTTP 422 to section 3.2 (as mentioned in #248)
https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#32-http-response-codes

@jpengar
Copy link
Collaborator

jpengar commented Jul 18, 2024

Add 422 UNIDENTIFIABLE_DEVICE error in Service Exceptions table (§6.1)

@bigludo7 @rartych @PedroDiez I would add it to Section 6.1 and to the table in Section 6.2, as with the other device-related error definitions.

@hdamker
Copy link
Collaborator

hdamker commented Jul 26, 2024

In addition it would good to add it also to artifacts/CAMARA_common.yaml for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants