Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an external-to-ref pass #1918

Closed
Tracked by #1733
nathanielnrn opened this issue Feb 16, 2024 · 3 comments · Fixed by #1952
Closed
Tracked by #1733

Create an external-to-ref pass #1918

nathanielnrn opened this issue Feb 16, 2024 · 3 comments · Fixed by #1952
Assignees
Labels
C: Calyx Extension or change to the Calyx IL

Comments

@nathanielnrn
Copy link
Contributor

nathanielnrn commented Feb 16, 2024

To ease the integration of Calyx programs into our AXI-wrapper #1733 it would be helpful to have an external-to-ref pass that changes toplevel memories marked @external to ref memories. I believe this would require changing part of the wellformedness check, which doesn't currently allow for ref in the toplevel? Unless we want to limit this pass to cases where we're using --synthesis flags.

Hopefully this would also help with any future work to deprecate @external in favor of ref, as discussed here.

@nathanielnrn nathanielnrn added the C: Calyx Extension or change to the Calyx IL label Feb 16, 2024
@nathanielnrn nathanielnrn self-assigned this Feb 16, 2024
@nathanielnrn
Copy link
Contributor Author

I will also say that this would be my first pass! So any pointing-in-the-right-direction would provide a big head start on this.

@sampsyo
Copy link
Contributor

sampsyo commented Feb 27, 2024

Yes, let's change that well-formedness check! IMO we should just disable it, as part of the @external deprecation effort (cf #1603 (comment)). --synthesis is also headed for the grave.

@nathanielnrn nathanielnrn linked a pull request Mar 3, 2024 that will close this issue
@nathanielnrn
Copy link
Contributor Author

Closed by #1952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Calyx Extension or change to the Calyx IL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants