-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build iOS - Turbo Module with Backward Compatibility - Fails #557
Comments
Update: It seems that by pushing the Podfile.lock after running: RCT_NEW_ARCH_ENABLED=1 bundle exec pod install solves the issue. So I guess that for the CI we should always push a Podfile.lock for the new architecture to ensure compatibility, although it seems strange. |
Hey looks like you were able to fix it by enabling the New Arch on this commit. So you most likely still have an issue on the current arch. And its failing on the current arch because it's not able to find the generated JSI spec (which is normal because you are not on the new arch) Here is the error from your build:
But its interesting that even though you are not building for the new arch, it still looks for the codegen generated code |
Hey @atlj! I'll run some tests in the upcoming days to check whether the same happens during a simple build process after a pod install. I'll gather some data if i can :) |
Hey I'm assuming this was fixed, please reopen if not. |
Description
Hi all,
I think this is related to how turbo is setup to handle cocoapods cache, therefore it may be a bug.
Basically I've got a library that supports both the old architecture and the new one.
My github action that runs: build:ios, fails saying the following:
It expects the output of Codegen (If i'm not mistaken) but my example app is not setup to build with the new architecture, so I don't understand how to properly fix this behaviour.
Locally i can't reproduce this issue, it runs smoothly.
Is it related to the pushed Podfile.lock?
If i delete the Podfile.lock, turbo resets the cocoapods cache and everything runs successfully, but I can't reset it everytime, I don't think that is the solution.
Has anyone got any idea?
My experience with Turbo is non-existent, so every help is really appreciated.
Thanks!
Packages
Selected options
✔ What is the name of the npm package? react-native-orientation-director
✔ What is the description for the package?
✔ What is the name of package author? gladiuscode
✔ What is the email address for the package author?
✔ What is the URL for the package author?
✔ What is the URL for the repository? https://github.com/gladiuscode/react-native-orientation-director
✔ What type of library do you want to develop? › Turbo module with backward compat
✔ Which languages do you want to use? › Kotlin & Objective-C
Link to repro
gladiuscode/react-native-orientation-director#1
Environment
React Native v74
Node 18
Yarn 3.x
The text was updated successfully, but these errors were encountered: