Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm mode check in registrationCompat #424

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

Sunbreak
Copy link
Contributor

Summary

develop mode condition is inspired by react-native-reanimated build.gradle

It uses the lock version of react-native dependency of library when compiling example

The lock version fails the build when there are different versions of react-native in each variant of examples

For example, https://github.com/Sunbreak/lottie-react-native/tree/compat-example

Test plan

lottie-react-native/lottie-react-native#1057 is PR of lottie-react-native for compat with react-native@0.69.4

@atlj atlj self-assigned this Jul 28, 2023
@atlj atlj added the enhancement New feature or request label Jul 28, 2023
@atlj
Copy link
Collaborator

atlj commented Jul 28, 2023

Seems like some of the pipelines are failing due to these changes.
Could you check the following for example: https://github.com/callstack/react-native-builder-bob/actions/runs/5629763026/job/15255089320?pr=424

  * Where:
  Build file '/home/runner/work/react-native-builder-bob/react-native-builder-bob/ubuntu-view-mixed-java-objc/android/build.gradle' line: 23
  
  * What went wrong:
  A problem occurred evaluating project ':bob_react-native-test'.
  > /home/runner/work/react-native-builder-bob/react-native-builder-bob/react-native/package.json (No such file or directory)

@Sunbreak
Copy link
Contributor Author

Sunbreak commented Aug 3, 2023

@atlj Could you check again?

@atlj
Copy link
Collaborator

atlj commented Aug 5, 2023

It looks good to me but I'd also like to get approval from @satya164

@atlj atlj requested a review from satya164 August 5, 2023 09:00
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@satya164 satya164 enabled auto-merge (squash) August 25, 2023 13:23
@satya164 satya164 merged commit 7fc7f1c into callstack:main Aug 25, 2023
31 of 32 checks passed
@Sunbreak Sunbreak deleted the fix-mode-check branch October 8, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants