Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): Add packager connection check #26

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

krizzu
Copy link

@krizzu krizzu commented Nov 12, 2019

Summary

If RN activity is launched without packager running, you'll see empty screen with no messages/views.
This PR adds a packager connection check on activity startup.

Test plan

  1. Install example app on the device/emulator
  2. Do not start packager
  3. Launch app, open React Native Activity screen
  4. You should see red box with connection error

@michalchudziak michalchudziak merged commit b39e8a0 into master Nov 19, 2019
@michalchudziak michalchudziak deleted the androidChanges branch December 2, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants