Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GNFA to_regex #74

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Refactor GNFA to_regex #74

merged 2 commits into from
Oct 20, 2022

Conversation

eliotwrobson
Copy link
Collaborator

@eliotwrobson eliotwrobson commented Oct 20, 2022 •
edited
Loading

Refactor GNFA to regex to comply with immutability and be iterative @caleb531

EDIT: Whoops, need to rebase real fast.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2f1db0a on eliotwrobson:gnfa_immutable_2 into bafd86a on caleb531:immutability.

@coveralls
Copy link

coveralls commented Oct 20, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4483c29 on eliotwrobson:gnfa_immutable_2 into bafd86a on caleb531:immutability.

@caleb531
Copy link
Owner

@eliotwrobson No worries, let me know when this PR is ready.

@caleb531 caleb531 marked this pull request as draft October 20, 2022 23:21
@eliotwrobson eliotwrobson marked this pull request as ready for review October 20, 2022 23:23
@eliotwrobson
Copy link
Collaborator Author

@caleb531 was an easy fix, should be good now.

@caleb531 caleb531 changed the title Refactor GNFA to regex Refactor GNFA to_regex Oct 20, 2022
@caleb531 caleb531 merged commit 1c2c99f into caleb531:immutability Oct 20, 2022
@eliotwrobson eliotwrobson mentioned this pull request Jan 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliotwrobson @coveralls @caleb531