Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH2941: Return empty process argument builder when values is null #2942

Merged
merged 1 commit into from
Feb 13, 2021
Merged

GH2941: Return empty process argument builder when values is null #2942

merged 1 commit into from
Feb 13, 2021

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented Nov 13, 2020

Fixes #2941.

@gitfool
Copy link
Contributor Author

gitfool commented Nov 13, 2020

Unrelated failure in ci/bitrise/42eaef77e8db4a5c/pr:

[xUnit.net 00:00:04.25]     [FATAL ERROR] System.AppDomainUnloadedException

devlead
devlead approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead enabled auto-merge February 13, 2021 13:41
@devlead devlead merged commit bd8769d into cake-build:develop Feb 13, 2021
@devlead
Copy link
Member

devlead commented Feb 13, 2021

@gitfool your changes have been merged, thanks for your contribution 👍

@gitfool gitfool deleted the gh2941 branch February 13, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProcessArgumentBuilder helpers should return empty builder when values is null
2 participants
@gitfool @devlead