Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH2908: Future proof .NET [Core] detection #2909

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented Oct 20, 2020

Fixes #2908 (using approach recommended in dotnet/runtime#12124 (comment)).

Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit cb68727 into cake-build:develop Oct 21, 2020
@devlead
Copy link
Member

devlead commented Oct 21, 2020

@gitfool your changes have been merged, thanks for your contribution 👍

@gitfool gitfool deleted the gh2908 branch October 21, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future proof .NET [Core] detection
3 participants