-
-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH502: Refactored ICakeEnvironment #1008
Conversation
Hi @patriksvensson, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
/// Determines whether the current machine is running Unix. | ||
/// </summary> | ||
/// <returns>Whether or not the current machine is running Unix.</returns> | ||
[Obsolete("Please use ICakeEnvironment.Platform.IsPosix instead.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong name of method.
Should we add an extension method to |
This included obsoleting a lot of members and also introducing two concepts, ICakePlatform and ICakeRuntime. ICakePlatform is an abstraction around the actual platform that Cake is running on. This will give you information about things such the operating system and architecture. ICakeRuntime is an abstraction around the runtime that Cake is running in such as the .NET target platform. Closes #502
@patriksvensson LGTM tested on several projects. I've rebased and merged into develop. |
This included obsoleting a lot of members and also
introducing two concepts,
ICakePlatform
andICakeRuntime
.ICakePlatform is an abstraction around the actual platform
that Cake is running on. This will give you information about
things such the platform family and architecture.
ICakeRuntime is an abstraction around the runtime that Cake
is running in such as the .NET target platform.
Closes #502