Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validator.onErrorForwardTo not working on 4.1.2 #906

Closed
Turini opened this issue Dec 15, 2014 · 3 comments · Fixed by #907
Closed

validator.onErrorForwardTo not working on 4.1.2 #906

Turini opened this issue Dec 15, 2014 · 3 comments · Fixed by #907
Assignees
@Turini
Labels
bug

Comments

@Turini
Copy link
Member

Turini commented Dec 15, 2014

as reported on this thread, the validator.onErrorForwardTo in case of constraints it is not forwarding.
@Turini Turini added the bug label Dec 15, 2014
@Turini Turini self-assigned this Dec 15, 2014
@Turini
Copy link
Member Author

Turini commented Dec 15, 2014

it's because viewsFactory.instanceFor internally uses result.use and with my
change on #867 it doesn't forward. I'll rollback my change and reopen #778 again =/

@Turini Turini mentioned this issue Dec 15, 2014
Merged
@renanigt
Copy link
Contributor

Isn't better generate a new version with the fix #907 ? Maybe new users try to use 4.1.2 and getting the problem.

@Turini
Copy link
Member Author

Turini commented Dec 17, 2014

Yes, you're right @renanigt. I'll wait until tomorrow for any review or better
suggestions on #907. I don't like my solution, returning the other old bug =/
After that, I think we can release the 4.1.3 with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Turini Turini

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removing result.used from forwardTo caelum/vraptor4
2 participants
@renanigt @Turini