-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 when the id is not found is not working #13
Comments
Hmm, @Turini what you think? |
hum, I think return to an interceptor would be the simpler option here. |
I'm thinking about this issue... and I was always opposed to throws an not found when an entity is not found. I think that is a decision that application knows, and not the framework. What you think to change this behavior to same as JPA says: if an entity is not found, only returns |
If the id is on the URL and the entity is not found, it's a 404. We shouldn't return null to the user. |
I agree with Lucas' comment. It's a 404 |
Guys, could you, please, re-validate the PR #31? Should I add docs about it? |
Since ParameterLoader is now an Observer, it can't stop the interceptor stack.
So, if the id is not found on database, even if
result.notFound()
is called, the controller method will also be called. =/Maybe we should change ParameterLoader to be an Interceptor again, and use methodInfo to set the parameter directly.
The text was updated successfully, but these errors were encountered: