-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matcher format for multiple sites share same definition #395
Comments
We should probably state that in the docs: there should be a space after the comma, not before. What you have there looks weird IMO 😇 I'm going to transfer this to the website repo so we can work on it there. |
https://github.com/caddyserver/caddy/blob/e7ecc7ede2f0f749530b0c2e685b99954b9591ce/caddyconfig/caddyfile/parse.go#L260 |
We don't actually want "fault tolerant" Caddyfiles, we want consistent ones 🙂 So the current behavior is correct, but we can clarify the specifics in the docs. |
Fixing the parser edgecase here caddyserver/caddy#6616 Also slight docs clarification: 6db3af5 |
I found put a space before comma will not parsed as two hosts, for example:
Is this a reasonable format? I'd like make a PR about it.
To quote the docs
Although the examples in the documentation are in the form of host immediately followed by a comma, this is, after all, not explicitly stated.
The text was updated successfully, but these errors were encountered: