Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: Make conns per host configurable, fix godocs #3829

Merged
merged 1 commit into from
Oct 30, 2020
Merged

reverseproxy: Make conns per host configurable, fix godocs #3829

merged 1 commit into from
Oct 30, 2020

Conversation

francislavoie
Copy link
Member

@francislavoie francislavoie commented Oct 29, 2020 •
edited
Loading

  • Makes max_conns_per_host configurable in Caddyfile
  • Adds new max_idle_conns_per_host option which is passed through to http.Transport, plus Caddyfile support
  • Fix godoc for buffer_requests (was in the wrong place) and add other missing options from http transport

This stuff came up after I read https://caddy.community/t/caddy-container-500-mb-ram-within-10h-1-gb-at-some-point/10070/13 which made me dig into this

I'll make a website PR as well after merged (unless you want me to do it asap?)

@francislavoie francislavoie added this to the v2.3.0 milestone Oct 29, 2020
@francislavoie francislavoie requested a review from mholt October 29, 2020 21:54
mholt
mholt approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this change!

If you submit a PR to the website before I get around to fixing it, go right ahead. Thank you again!

@mholt mholt merged commit b660993 into caddyserver:master Oct 30, 2020
@francislavoie francislavoie deleted the proxy_conn_limits branch October 30, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@francislavoie @mholt