Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverseproxy: Implement cookie selection policy #3809

Merged
merged 11 commits into from
Nov 20, 2020

Conversation

d-masson
Copy link
Contributor

@d-masson d-masson commented Oct 19, 2020

Rebase master on @utick branch and try to manage @francislavoie remark on #3408

Fix #3409

@CLAassistant
Copy link

CLAassistant commented Oct 19, 2020

CLA assistant check
All committers have signed the CLA.

@francislavoie francislavoie changed the title Stickysession reverseproxy: Implement cookie selection policy Oct 22, 2020
@francislavoie francislavoie added this to the v2.3.0 milestone Oct 22, 2020
@mholt
Copy link
Member

mholt commented Nov 4, 2020

Thanks. I'm liking this, but I still need to commit myself to the idea that the load balancer can modify the response. I feel like that should happen separately, but... that might be just as easy to abuse/break... I'll think about it.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I think I'm finally OK with modifying the response in a selection policy; the user should still be able to control that through configuration so I think it's OK.

Just a few changes requested before we accept this.

modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
modules/caddyhttp/reverseproxy/selectionpolicies.go Outdated Show resolved Hide resolved
@mholt mholt added the under review 🧐 Review is pending before merging label Nov 16, 2020
@d-masson d-masson force-pushed the stickysession branch 2 times, most recently from b953e9d to 5a99e36 Compare November 18, 2020 17:59
@d-masson d-masson force-pushed the stickysession branch 2 times, most recently from 69b3909 to 7e9afb7 Compare November 18, 2020 18:52
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reverseproxy: Add cookie lb_policy to enhance session affinity support
5 participants