-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverseproxy: Implement cookie
selection policy
#3809
Conversation
cookie
selection policy
3df3455
to
776b0c2
Compare
Thanks. I'm liking this, but I still need to commit myself to the idea that the load balancer can modify the response. I feel like that should happen separately, but... that might be just as easy to abuse/break... I'll think about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! I think I'm finally OK with modifying the response in a selection policy; the user should still be able to control that through configuration so I think it's OK.
Just a few changes requested before we accept this.
b953e9d
to
5a99e36
Compare
5a99e36
to
e43e820
Compare
69b3909
to
7e9afb7
Compare
7e9afb7
to
51e5675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks so much for your contribution!
Rebase master on @utick branch and try to manage @francislavoie remark on #3408
Fix #3409