reverseproxy: Logging for streaming and upgrades #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
requested changes
Aug 31, 2020
There was a problem hiding this comment.
Ah thanks. I don't think there's any reason we need to do things the same way the std lib logger worked/works. We can use the normal structured logs. And some of these should/could be different levels. I'm not super sure which levels are the right ones all the time but let me know if you disagree on any!
francislavoie
force-pushed
the
upgrade-conn-logging
branch
from
708c420 to
d060b30
Compare
mholt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://caddy.community/t/caddy-reverse-proxy-to-another-domain/9589/6
Looks like we forgot to set up logging here. I'm not sure if using the sugared logger is ideal, but it's the easiest way to get this working as similarly to the stdlib implementation I think.