httpserver: Add H2C support #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have not tested this yet
This was
linked to
issues
Apr 21, 2020
|
I still need to do a little cleanup/finalization of the h2c-related config, then this PR will be out of draft phase. |
# Conflicts: # modules/caddyhttp/responsewriter.go # modules/caddyhttp/reverseproxy/httptransport.go
francislavoie
approved these changes
Apr 22, 2020
Closed
|
Will it support Caddyfile? |
|
@AkinoKaede The Caddyfile does not currently support this, because the Caddyfile is not structured around server-level settings (but rather, site-level settings), in other words: it is not possible to enable H2C for one site and disable it for another, it has to either be enabled or disabled for the whole server, but the Caddyfile doesn't have a good way to express that unless we enable H2C for all servers globally. |
|
The issue #3669 is tracking Caddyfile support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft enables optional H2C support, both in the server and in the reverse proxy.
It also fixes a bug when recording responses (used primarily with HTTP access logging enabled, or the templates middleware) where trailers weren't properly getting flushed to the underlying response writer. As a bonus, that particular fix deletes code, eliminates copies, and should slightly improve performance!
Need to finalize the API before we merge this, but it should be ready shortly after the 2.0 release. Do not merge before 2.0.
@Zetanova could you please test this out? 👍
Edit: Should be ready. On a server, you can set
"allow_h2c": trueto enable H2C support as a server, and on the proxy you can specify"h2c"as one of the Versions values of the HTTP Transport to enable the H2C client.