Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour when simulating multiple configurations #248

Closed
BenSchZA opened this issue Jan 14, 2021 · 2 comments
Closed

Unexpected behaviour when simulating multiple configurations #248

BenSchZA opened this issue Jan 14, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@BenSchZA
Copy link
Member

When adding multiple configuration objects to the global cadCAD configs list, the results are unexpected. I'm sure it relates to this statement in the docs:

As of now it does not support multi - system model simulation because configurations are still appended globally despite append_config being a method of Experiment.

https://gist.github.com/BenSchZA/7b7052ffcd65c5645d65b3e6bb56b329

At the end of the above notebook, I calculated the expected number of rows, if A/B testing was possible. This is also related to issue #247 (comment) I believe.

@JEJodesty
Copy link
Member

JEJodesty commented Jun 30, 2021

The previous release was returning partial results therefore a benchmark at this time is unwarranted
A/B tested for future release

self.assertEqual(record_count_0_4_24 > record_count_0_4_23, True, "Invalid Row Count for current version")

Updated Build:
https://github.com/cadCAD-org/cadCAD/tree/staging

@JEJodesty
Copy link
Member

JEJodesty commented Aug 26, 2021

Resolved by version 0.4.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants