-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hex-grid is broken since 1.2.0 #407
Comments
Thanks for looking into it. My take is just to remove the component from the repository. If someone is interested in reviving a hexgrid component, they can contribute one as a separate repository. Can you please create a PR that removes all the related files? |
Merged
The hexgrid component was removed in #408. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hex-grid has a dependency on THREE.Geometry, so has been broken since 1.2.0.
I've been looking into options for fixing.
hex-grid is based on this repo (the build from this is here)
https://github.com/vonWolfehaus/von-grid
Status of this repo is described as follows.
The dev branch appears to have moved from Geomrty to BufferGeometry. However that dev branch is described as "incomplete", and is untouched since Feb 2017.
The project doesn't have any unit tests, making maintenance by an unfamiliar developer fairly high-risk.
From a brief skim of the 73 forks of the project, I don't see any that has any significant later work done on it.
Options for repaiting hex-grid component in this repo:
Option 1 is probably OK short-term, but feels like a poor long-term choice.
I don't fancy taking on 2 or 4, at least not in the short-term.
Some digging on 3 led to...
A. https://www.youtube.com/watch?v=4fC2fuVdsyA
B. https://github.com/Bunkerbewohner/threejs-hex-map
C. https://github.com/flauwekeul/honeycomb
D. https://hofk.de/main/discourse.threejs/BeginnerExample/BeginnerExample.html#:~:text=function%20createHoneyComb(%20radius%2C%20rings%2C%20thick%2C%20depth%20)%20%7B
Bottom line, no viable candidates for option 3 that I can find.
Net of this - no good options for reviving hex-grid at this point, without significant work (2, 3 or 4), or creating substantial future maintenance liabilities (1).
The text was updated successfully, but these errors were encountered: