Behavior of CCIO.File.read_dir ~recurse:true

[FardaleM]

The function CCIO.File.read_dir list directory if recurse is false but does not if recurse is true. That's quite a surprising behavior. Maybe we should just split into another function to have the second behavior.

[c-cube]

I would consider that to be a bug, and thus amenable to a breaking change :-).

[FardaleM]

I see, what should be the behavior of CCIO.File.read_dir recurse:true? Should it output everything including the directories?

[FardaleM]

Just so that I don't forget, this behavior was mention here

ocaml-containers/src/core/CCIO.mli

Line 186 in a127e13

See {!File.walk} if you also need to list directories:

but not in the doc of the function.

[c-cube]

that's a good point, I forgot that the functionality exists already. Maybe we could just update the docs then.