Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for primitive types #27

Merged
merged 2 commits into from
Nov 25, 2018
Merged

Conversation

kowalczm
Copy link

In performant applications boxing/unboxing primitive numeric values can be overkill.

@kowalczm
Copy link
Author

kowalczm commented Nov 25, 2018

Hi @bytefish ,
That would be my last commit for today :) and I think that would be all for now from my side. It would be good to have release after this change.

Best Regards,
Mariusz

@bytefish
Copy link
Member

@kowalczm Very clever usage of a Functional interface to have a nice API. 😎 Also good you added Unit Tests. I don't think duplicating the COPY implementation for primitive types is much of a problem, maybe we can refactor this into a Static Method in the specific Value Handler and call it.

@bytefish bytefish merged commit 165d127 into PgBulkInsert:master Nov 25, 2018
@bytefish
Copy link
Member

@kowalczm Mariusz, many thanks for your additions to the library! I have just released the Version 3.1 to the Maven Central Repository, so the Release will be indexed within the next hours. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants