From 241439d771eb7ee1a325c28899bfa0f4aead4a99 Mon Sep 17 00:00:00 2001 From: Ian Ker-Seymer Date: Mon, 14 Nov 2022 16:33:57 -0500 Subject: [PATCH] Run on every push --- .github/workflows/{mem.yml => memcheck.yml} | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) rename .github/workflows/{mem.yml => memcheck.yml} (71%) diff --git a/.github/workflows/mem.yml b/.github/workflows/memcheck.yml similarity index 71% rename from .github/workflows/mem.yml rename to .github/workflows/memcheck.yml index 4eebd88e..43403f62 100644 --- a/.github/workflows/mem.yml +++ b/.github/workflows/memcheck.yml @@ -1,11 +1,11 @@ --- -name: Run memory checks +name: Memcheck on: workflow_dispatch: inputs: ruby-version: - description: 'Ruby version to mem-check' + description: 'Ruby version to memcheck' required: true default: '3.1' type: choice @@ -15,11 +15,10 @@ on: - '3.0' - '2.7' push: - branches: ["main", "mem/*"] jobs: memcheck: - name: Run memory checks + name: Memcheck runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 @@ -40,10 +39,8 @@ jobs: bundle config set deployment true - name: Run "mem:check" task - run: bundle exec rake mem:check - - - name: Halp! - if: failure() run: | - msg="Valgrind memory check failed, for more info please see ./suppressions/readme.md" - echo "::error::$msg" + if ! bundle exec rake mem:check; then + echo "::error::Valgrind memory check failed, for more info please see ./suppressions/readme.md" + exit 1 + fi