Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Result in safe wrappers? #4

Closed
newpavlov opened this issue Aug 14, 2019 · 0 comments · Fixed by #5
Closed

Use Result in safe wrappers? #4

newpavlov opened this issue Aug 14, 2019 · 0 comments · Fixed by #5

Comments

@newpavlov
Copy link
Contributor

newpavlov commented Aug 14, 2019 •
edited
Loading

Right now you use tuples in safe wrappers instead of idiomatic Results. Is there a reason for that?

To be more efficient you can define Errno as NonZeroU16, so Result<(), Errno> would take strictly 2 bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Result in idiomatic wrappers, mark most wrappers as unsafe fn newpavlov/rust-wasi
1 participant
@newpavlov