Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on the wit and wat features by default. #46

Closed
rylev opened this issue Feb 2, 2024 · 1 comment · Fixed by #49
Closed

Turn on the wit and wat features by default. #46

rylev opened this issue Feb 2, 2024 · 1 comment · Fixed by #49

Comments

@rylev
Copy link
Collaborator

rylev commented Feb 2, 2024

It's not entirely clear to me why we wouldn't want the wit and wat features on by default. I would suggest turning them on by default. The registry feature still might make sense to have off by default since registries are still quite new.

@peterhuene
Copy link
Member

The wat feature is mostly for the tests, as users will rarely want to author a component in the text format to be used with the tool.

The thinking of having wit behind a feature is that eventually wit packages will be from the registry in most cases.

The intention behind both was simply to limit dependencies.

That said, we should probably be defaulting the wit feature on as the registry feature is defaulted off; we can then default it to off once registry is defaulted to on.

Feel free to make that change or I can do so when I'm back on Monday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants