Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add package keyword to wit grammar #19

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Conversation

eduardomourar
Copy link
Collaborator

@eduardomourar eduardomourar commented Jul 3, 2023

BREAKING CHANGE: The default, self, pkg keywords have been removed from the grammar.

Based on proposal here:

  • default, self, pkg are no longer keywords anymore
  • package <namespace>:<name> is a new document-level syntax sitting on top of the file

Related to: #15.

@eduardomourar eduardomourar marked this pull request as ready for review July 4, 2023 18:04
@eduardomourar eduardomourar requested a review from Mossaka July 4, 2023 18:04
@eduardomourar eduardomourar merged commit f450c32 into main Jul 8, 2023
@eduardomourar eduardomourar deleted the feat/package-keyword branch July 8, 2023 06:39
eduardomourar added a commit that referenced this pull request Jul 8, 2023
BREAKING CHANGE: The `default`, `self`, `pkg` keywords
have been removed from the grammar.

Based on proposal
[here](WebAssembly/component-model#193):
- `default`, `self`, `pkg` are no longer keywords anymore
- `package <namespace>:<name>` is a new document-level
syntax sitting on top of the file

Related to:
#15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant