Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcsetwinsize should use &Winsize #1083

Closed
tianyuanhao opened this issue Jul 1, 2024 · 1 comment
Closed

tcsetwinsize should use &Winsize #1083

tianyuanhao opened this issue Jul 1, 2024 · 1 comment
Labels
semver bump Issues that will require a semver-incompatible fix

Comments

@tianyuanhao
Copy link

tianyuanhao commented Jul 1, 2024 •
edited
Loading

🤔 I find that only references to Winsize are used in the implementation.

Refs: #671, #673

✨ I've understood. It's because Winsize is too small, so it's OK to pass the value directly, right?
@sunfishcode sunfishcode added the semver bump Issues that will require a semver-incompatible fix label Jul 2, 2024
@sunfishcode
Copy link
Member

I believe either way works and that it's just a question of API convenience and perhaps low-level optimization. I think the original idea was that passing it by value would be more convenient, but I'd be interested in hearing how it works out in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver bump Issues that will require a semver-incompatible fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunfishcode @tianyuanhao