-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deno support #102
Comments
Thanks for the feedback here, can you share the example WIT and flags you were using to get the above output with |
Unfortunately, it seems TypeScript itself doesn't like the
|
@guybedford Thanks for looking into this. Wit can be found here and we are using jco 0.7.0 because we cannot support yet component version 3 in all hosts (waiting for Python support). |
I saw your issue because it was linked to mine. Python support for component version 3 happened in wasmtime-py, so you can now go on with development. |
@iulian-birlica Thanks for letting us know. @guybedford I can confirm same issue happens with latest version. |
@zifeo if we replace the |
@guybedford Here is the wit and use case: Repro & WIT files with:
There is a few things looking weird:
What do you advise here? We currently run a bash script to fix those points. |
@zifeo I think I agree with you that an explicit Are you interested in contributing to the project? Otherwise I will get to this one when I can. |
@guybedford let's see whether we can give it a try in the next days. How should the first element be handled "imports and exports seems inverted", is that expected or is there something we are not following for that? |
@zifeo I can take a look at the other issues from the case, but couldn't get the clone to work as the |
@guybedford sorry, the PR got merged, can you retry now? I restored the branch :) |
@zifeo just had a look and this is the WIT I get for
And here is the main generated TypeScript file: import { ImportsAbi } from './imports/abi';
import { ExportsMetatypeTypegraphCore } from './exports/metatype-typegraph-core';
import { ExportsMetatypeTypegraphRuntimes } from './exports/metatype-typegraph-runtimes';
export const core: typeof ExportsMetatypeTypegraphCore;
export const runtimes: typeof ExportsMetatypeTypegraphRuntimes; This matches correctly - The file name does include the full name as well it seems. Let me know if there's something I'm missing, otherwise I think it's just the Deno extension issue here then? |
@guybedford look at the file |
Thanks again for the report here. I believe the cases here were fixed, but please reopen if we're still missing anything. |
@guybedford Sorry the late answer, the version 0.12.1 works better, thanks! There is a Deno incompatibility due to the file extension. A simple post processing is enough: |
Great work! The library seems overall to work well with Deno, some syntax updates are nonetheless required:
.d.ts
components.d.ts
files syntax is not recognizedThe text was updated successfully, but these errors were encountered: