Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescriptify Phase V πŸ§žβ€β™‚οΈπŸ§žβ€β™€οΈ #744

Merged
merged 9 commits into from
Oct 1, 2020

Conversation

ZeeJab
Copy link
Contributor

@ZeeJab ZeeJab commented Sep 10, 2020

This PR is Phase 5 of migrating the mobiledoc-kit lib to typescript. The focus here was the Editor + enabling noImplicitAny!!

In a previous PR I had updated some dependencies, but I rolled some of those back in this one due to unnecessary additional complications they were introducing for this particular phase.

This marks the end of migrating all the implementation code into TS. The next phases will be focused on migrating tests.

@ZeeJab ZeeJab changed the title [WIP] Typescriptify Phase 5 πŸ§žβ€β™‚οΈπŸ§žβ€β™€οΈ Typescriptify Phase V πŸ§žβ€β™‚οΈπŸ§žβ€β™€οΈ Sep 23, 2020
@ZeeJab ZeeJab requested a review from tomdale October 1, 2020 13:40
Copy link
Collaborator

@tomdale tomdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ€ͺπŸ₯ΆπŸ˜·

@ZeeJab ZeeJab merged commit 974a8e9 into master Oct 1, 2020
@ZeeJab ZeeJab deleted the zeejab/typescript-phase-5 branch October 6, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants