Implement Mobiledoc 0.3.2 (text alignment attribute) (continued) #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
reviewed
Jul 16, 2019
| @@ -953,6 +953,10 @@ class Editor { | |||
| this.run(postEditor => postEditor.toggleSection(tagName, this.range)); | |||
| } | |||
|
|
|||
| setAttribute(key, value) { | |||
There was a problem hiding this comment.
Not sure this is needed, we could just document the postEditor version. But I'm not sure it is harmful. Should get jsdoc.
|
Sauce labs seems to be overloaded, or to have changed the way you are expected to refer to IE11 and friends. Seems odd, and unrelated to these changes which have no reason to be broken on older browsers. I'm going to land this into master and will cut at least a beta release for immediate testing/use. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued work from #682. The tests on CI fail because I'm using pointing to the branches for bustle/mobiledoc-dom-renderer#62 and bustle/mobiledoc-text-renderer#22, and these changes are not merged and not pushed to NPM.
TODO
setAttributesetAttributeon the demo website (after new website deployed)Other changes
Curious to have your thoughts @mixonic and @bantic!