Allow reading range from DOM when editor is disabled #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `_readRangeFromDOM` doesn't do anything if the editor is non-editable, the editor may get stuck with a range that is pointing at a section that has been removed from the post. This causes the error seen when doing the `post.walkAllLeafSections` later in the snapshot code. The post is undefined because it is read off the card, but the card that the range points at has been removed. Fixes #475
bantic
force-pushed
the
fix-bug-where-moving-a-card-in-non-editable-errors
branch
from
3416431
to
de0b954
Compare
|
released in v0.10.9 |
johnelliott
pushed a commit
to dailybeast/mobiledoc-kit
that referenced
this pull request
Feb 7, 2017
…le#476) Because `_readRangeFromDOM` doesn't do anything if the editor is non-editable, the editor may get stuck with a range that is pointing at a section that has been removed from the post. This causes the error seen when doing the `post.walkAllLeafSections` later in the snapshot code. The post is undefined because it is read off the card, but the card that the range points at has been removed. Fixes bustle#475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
_readRangeFromDOMdoesn't do anythingif the editor is non-editable, the editor may get stuck with a range
that is pointing at a section that has been removed from the post.
This causes the error seen when doing the
post.walkAllLeafSectionslater in the snapshot code. The post is undefined because it is read off
the card, but the card that the range points at has been removed.
Fixes #475