Refactor rendering of editor element #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a new class name ("__has-no-content") to the editor element when
the post has no content will simplify rendering of the placeholder text
later.
* Add `Post#hasContent` (fixes #335)
* Add `editor#focus()`
* Move EDITOR_ELEMENT_CLASS_NAME to renderers/editor-dom
* Make the editor-dom renderer responsible for adding EDITOR_ELEMENT_CLASS_NAME
* Make the editor-dom renderer responsible for adding EDITOR_HAS_NO_CONTENT_CLASS_NAME if post has no content
bantic
force-pushed
the
editor-post-has-content
branch
from
cc75d40
to
28632d5
Compare
|
released in v0.10.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new class name ("__has-no-content") to the editor element when
the post has no content will simplify rendering of the placeholder text
later.
Post#hasContent(fixes Add Post#hasContent #335)editor#focus()