Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add onTextInput to README, add example to docs #398

Open
bantic opened this issue May 12, 2016 · 1 comment
Open

docs: add onTextInput to README, add example to docs #398

bantic opened this issue May 12, 2016 · 1 comment

Comments

@bantic
Copy link
Collaborator

bantic commented May 12, 2016

As mentioned in Gitter by @martinklepsch, the readme should mention onTextInput here: https://github.com/bustlelabs/mobiledoc-kit#editor-api
And inline documentation should be added to the method definition in editor.js

@mixonic
Copy link
Contributor

mixonic commented May 13, 2016

We still need some inline docs.

Aside: Is there a benefit to having the matcher pass as a property on options? Perhaps the key pressed should simply be passed as an argument to the hook, unifying it with other hook argument signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants