chore(tests): Ensure TestLoader module load failures are counted as t…

…est failures (#541)

tests/helpers/assertions.js

@@ -125,7 +125,7 @@ function comparePostNode(actual, expected, assert, path='root', deepCompare=fals
   }
 }
 
-export default function registerAssertions() {
+export default function registerAssertions(QUnit) {
   QUnit.assert.hasElement = function(selector,
                                      message=`hasElement "${selector}"`) {
     let found = $(selector);
@@ -317,5 +317,4 @@ export default function registerAssertions() {
       });
     }
   };
-
 }

tests/helpers/module-load-failure.js

@@ -0,0 +1,25 @@
+import TestLoader from 'ember-cli/test-loader';
+
+/**
+ * Ensures that when the TestLoader failures to load a test module, the error
+ * is reported. Without this the rest of the full test suite still passes and there is an
+ * error printed in the console only.
+ * The technique is from: https://github.com/ember-cli/ember-cli-qunit/blob/master/vendor/ember-cli-qunit/test-loader.js#L55
+ */
+export default function(QUnit) {
+  var moduleLoadFailures = [];
+
+  TestLoader.prototype.moduleLoadFailure = function(moduleName, error) {
+    moduleLoadFailures.push(error);
+    QUnit.module('TestLoader Failures');
+    QUnit.test(moduleName + ': could not be loaded', function() {
+      throw error;
+    });
+  };
+
+  QUnit.done(function() {
+    if (moduleLoadFailures.length) {
+      throw new Error('\n' + moduleLoadFailures.join('\n'));
+    }
+  });
+}

tests/test-helpers.js

@@ -1,5 +1,9 @@
+/* global QUnit */
 import registerAssertions from './helpers/assertions';
-registerAssertions();
+registerAssertions(QUnit);
+
+import registerModuleLoadFailureHandler from './helpers/module-load-failure';
+registerModuleLoadFailureHandler(QUnit);
 
 import DOMHelpers from './helpers/dom';
 import MobiledocHelpers from './helpers/mobiledoc';